[Bug 237170] Review Request: repoman - Tool for configuring yum(8) settings and repositories

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: repoman - Tool for configuring yum(8) settings and repositories


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=237170





------- Additional Comments From dcantrell at redhat.com  2007-04-23 14:19 EST -------
(In reply to comment #1)
> It looks like you also need a sponsor?

Yes.

> 1. The source url doesn't seem quite right
> http://www.boston.burdell.org/repoman/src/repoman-0.7.tar.gz
> works. (ie, it needs a /src/ in there)

Fixed.

> 2. rpmlint says:
> 
> a) W: repoman no-dependency-on usermode
> 
> Should "Requires: usermode" since you have a link to consolehelper.

Fixed.
 
> b) W: repoman incoherent-version-in-changelog 0.7 0.7-1.fc7
> 
> Should have the Release on the versions in the changelog...
> ie, 0.7-1

Fixed.

> c)
> W: repoman conffile-without-noreplace-flag /etc/pam.d/repoman
> W: repoman conffile-without-noreplace-flag /etc/security/console.apps/repoman
> 
> Are users ever likely to modify those files? Should they be noreplace?

Most likely users will never have to modify those files.  But, they are config
files and we wouldn't go to the trouble of making them config files if we didn't
want to give the users the option of changing them.  I've added the noreplace
attribute.

> 2. You shouldn't need to require desktop-file-utils anymore, also you
> might use the standardized scriptlet for updating the mime-type key. See:
>
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-de6770dd9867fcd085a73a4700f6bcd0d10294ef

Fixed.

> 3. You should use desktop-file-install to install the .desktop file:
>
http://fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8cecc219d8f73926e9755

Fixed, I think.  Not sure if I'm using this correctly.

> 4. Is there a reason for the (8) after yum in the summary and description?
> I find it distracting, and many people won't know what it means.

Only to indicate it's a command with a man page.  Removed the (8).

> Finally two items that are by no means blockers, but I thought I would mention:
> 
> - Perhaps you could talk with the yum-presto maintainer and see if it would
> be possible/easy to add support for deltarpm repos when they appear?

Definitely something to look in to.  Added it to the TODO list.

> - I see that this application doesn't have an icon. Perhaps you could ask for
> someone on the art group to whip one up?
> http://fedoraproject.org/wiki/Artwork/DesignService

Also added to the TODO list.

I have put all of these changes together in repoman-0.8.  Here is the new srpm
and spec file:
http://www.boston.burdell.org/repoman/RPMS/source/repoman-0.8-1.fc7.src.rpm
http://www.boston.burdell.org/repoman/RPMS/source/repoman.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.