[Bug 170303] Review Request: google-perftools: Very fast malloc & performance analysis tools

bugzilla at redhat.com bugzilla at redhat.com
Tue Apr 24 11:12:34 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: google-perftools: Very fast malloc & performance analysis tools


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=170303





------- Additional Comments From dmitry at butskoy.name  2007-04-24 07:12 EST -------
I'm still here... ;)

All checks are OK under FC5 i386 !


Questions:

It seems that libunwind is not strongly required.
I've successfully built google-perftools under FC5/i386 without it at all. Since
there is no libunwind in FC5 and FC6 distros, and since the trying to build it
under FC5/i386 was failed (due to failed checks), maybe drop this BR, or at
least use this BR for particular arch (64) only?

Patching of both Makefile.am and Makefile.in files looks like not very good way,
AFAIK in such a case we should patch *.am and run some autotools to update *.in 

Are there some more elegant ways for adding of libstacktrace to link stage?
Maybe some unique change is possible (i.e. common LIBS, or something in
Makefile.am and autoconf etc.)?


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list