[Bug 225248] Merge Review: ant

bugzilla at redhat.com bugzilla at redhat.com
Tue Apr 24 22:06:20 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: ant


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225248





------- Additional Comments From pcheung at redhat.com  2007-04-24 18:06 EST -------
(In reply to comment #2)
> Good:
> + Naming seems ok.
> + Tar ball matches with upstream.
> + Mock build works fine for FC6 and rawhide.
> 
> Bad:
> - BR coreutils is not be included.
BR coreutils removed.
> - warning from rpmlint ant-manual:
> 
> rpmlint of ant-manual:
> W: ant-manual dangling-symlink /usr/share/doc/ant-manual-1.6.5/manual/api
> /usr/share/javadoc/ant-1.6.5
> W: ant-manual symlink-should-be-relative
> /usr/share/doc/ant-manual-1.6.5/manual/api /usr/share/javadoc/ant-1.6.5
These are needed so that different versions of docs can be installed on the same
machine. The symlink points to a macro, so it cannot be make relative.
> W: ant-manual file-not-utf8
> /usr/share/doc/ant-manual-1.6.5/manual/tutorial-tasks-filesets-properties.zip
This zip is taken directly from the source tar ball.

> - Errors/warnings on rpmlint ant:
> E: ant devel-dependency java-devel
ant needed java-devel to run some of its tasks.
> W: ant non-standard-group Development/Build Tools
The group warning is OK.
> W: ant incoherent-version-in-changelog 1.6.5-4jpp.2 0:1.6.5-4jpp.2.fc6
Fixed
> W: ant obsolete-not-provided ant-optional
> W: ant obsolete-not-provided ant-optional-full
I tried adding these Provides, but then the main package conflicts with the
sub-packages, so these were removed.
> E: ant useless-explicit-provides ant
That Provides: allows subpackages not in Fedora to be installed from JPackage.

Updates srpm and spec file at the same location.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list