[Bug 223592] Review Request: wuja - Gnome desktop applet for integration with Google calendar

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wuja - Gnome desktop applet for integration with Google calendar


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223592





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-04-27 03:56 EST -------
For 0.0.7-1:

------------------------------------------------
* MUST/SHOULD fix: If you have some reason you don't
                   want to fix, please explain why.
? Question/Suggestion
------------------------------------------------

? %pre entry
  - Would you write %pre section after
    %install section?

* Requires
  - Some missing Requires found.
    Python releated dependencies are not checked by rpmbuild
    automatically, so you have to check it by yourself.
    From
-------------------------------------------------
$ grep -h 'import ' `rpm -ql wuja` | sort | uniq
-------------------------------------------------
import pynotify  -> notify-python (available on FC6<=)
from egg import trayicon -> gnome-python2-libegg
import gconf -> gnome-python2-gconf
import gtk (and others) -> pygtk2
-------------------------------------------------
   ! Just a note:
     Currently I get the following warning of deprecated
     module:
-------------------------------------------------
/usr/lib/python2.5/site-packages/wuja/application.py:35: DeprecationWarning: the
module egg.trayicon is deprecated; equivalent functionality can now be found in
pygtk 2.10
  from egg import trayicon
-------------------------------------------------

* CFLAGS
  - While this is a noarch rpm, do you have to set CFLAGS?

* Provides
-------------------------------------------------
Provides: wuja = %{version}-%{release}
-------------------------------------------------
  - This is not needed and should be removed.

Then:
-------------------------------------------------------------
NOTE: Before being sponsored:

This package will be accepted with another few work. 
But before I accept this package, someone (I am a candidate) 
must sponsor you.

Once you are sponsored, you have the right to review other 
submitters' review requests and approve the packages formally. 
For this reason, the person who want to be sponsored (like you) 
are required to "show that you have an understanding 
of the process and of the packaging guidelines" as is described
on :
http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored

Usually there are two ways to show this.
A. submit other review requests with enough quality.
B. Do a "pre-review" of other person's review request
   (at the time you are not sponsored, you cannot do
   a formal review)

When you have submitted a new review request or have pre-reviewed other 
person's review request, please write the bug number on this bug report 
so that I can check your comments or review request.

Fedora Extras package review requests which are waiting for someone to
review can be checked on:
https://bugzilla.redhat.com/bugzilla/buglist.cgi?cmdtype=runnamed&namedcmd=mtasaka-review-noone
NOTE: FE-NEW blockers are now not complete.

Review guidelines are described mainly on:
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
------------------------------------------------------------


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.