[Bug 229323] Review Request: PgpoolAdmin - web-based pgpool administration

bugzilla at redhat.com bugzilla at redhat.com
Fri Apr 27 11:55:13 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: PgpoolAdmin - web-based pgpool administration


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229323


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|normal                      |medium

limb at jcomserv.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |limb at jcomserv.net




------- Additional Comments From limb at jcomserv.net  2007-04-27 07:55 EST -------
rpmlint on SRPM:
W: postgresql-pgpoolAdmin mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 3)
The specfile mixes use of spaces and tabs for indentation, which is a
cosmetic annoyance.  Use either spaces or tabs for indentation, not both.

Should be an easy fix.

on RPM: 
W: postgresql-pgpoolAdmin symlink-should-be-relative
/usr/share/postgresql-pgpoolAdmin/conf/pgmgt.conf.php
/etc/postgresql-pgpoolAdmin/pgmgt.conf.php
Absolute symlinks are problematic eg. when working with chroot environments.

W: postgresql-pgpoolAdmin dangerous-command-in-%post chmod

Instead of chmod in %post, set permissions with an %attr tag on the %files
section.  Much safer.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list