[Bug 233975] Review Request: freefem++ - PDE solving tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: freefem++ - PDE solving tool


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233975





------- Additional Comments From mr.ecik at gmail.com  2007-04-27 15:49 EST -------
REVIEW:

 * %{?dist} tag's present
 * package's licensed under LGPL and license's included in package
!* rpmlint output:

W: freefem++-glx non-standard-group Applications/Scientific

Why don't use Applications/Engineering as in the main package?

W: freefem++-glx no-documentation
E: freefem++ binary-or-shlib-defines-rpath /usr/bin/FreeFem++-client ['/usr/
lib64']
E: freefem++ binary-or-shlib-defines-rpath /usr/bin/FreeFem++-cs ['/usr/lib64']
E: freefem++ binary-or-shlib-defines-rpath /usr/bin/FreeFem++-ide ['/usr/lib64']

Has to be fixed. Unfortunately, I'm currently unable to check if the way to fix 
the rpath from PackagingGuidelines works for this package, but it should be 
checked.

W: freefem++ spurious-executable-perm /usr/share/man/man1/FreeFem++.1.gz

Change wrong permissions

E: freefem++-debuginfo script-without-shebang /usr/src/debug/freefem++-2.14-1/
src/fflib/mt19937ar.cpp
E: freefem++-debuginfo script-without-shebang /usr/src/debug/freefem++-2.14-1/
src/lglib/mymain.cpp
W: freefem++-mpi non-standard-group Applications/Scientific
W: freefem++-mpi no-documentation

 * md5sums match each other. However, 2.14 is not the newest freefem++'s 
release so you have to package the newer version
 * BRs seem to be proper, mock fc6/x86_64 builds fine
 * final provides and requires are sane
 * package doesn't create any new directory and it doesn't own any one it 
shouldn't
 * %clean section fine
 * build root's proper
!* %files sections don't look good. Manpage has improper permissions. Also, it 
doesn't seem to me that setting 755 permissions globally is a good solution 
'cause it lead up to wrong permissions (as in the manpage case) so I'll suggest 
to change it
 * except for Group tag, everything related with subpackages seems good


THINGS TO DO:
 * change subpackages' groups
 * fix rpath issue
 * package the newer version
 * fix permissions of manpage
 * don't set 755 permissions globally


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.