[Bug 238235] Review Request: TastyMenu - KMenu replacement aiming to provide the maximum usability

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: TastyMenu - KMenu replacement aiming to provide the maximum usability


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238235





------- Additional Comments From laurent.rineau__fedora_extras at normalesup.org  2007-04-28 15:31 EST -------
Nice work!  tastymenu-0.7.1-1fc6.src.rpm seems a far better packaging than the 
previous one. There is still the issue of ${_libdir}/ tastymenu_panelapplet.so

And your BuidlRequires are a little too long. "BuildRequires: qt-devel, 
kdelibs-devel" should be enough, even though it is not a critical issue. I 
have not looked that the compilation itself, but why kdebase is 
build-required?

I copy-paste the issues found by rpmlint below:

lrineau at tsetse ~/RPM $ rpmlint SRPMS/tastymenu-0.7.1-1.amoi_rineau.src.rpm
W: tastymenu mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 42)
lrineau at tsetse ~/RPM $ rpmlint tastymenu
W: tastymenu incoherent-version-in-changelog 1 0.7.1-1.amoi_rineau
E: tastymenu invalid-soname /usr/lib/tastymenu_panelapplet.so 
tastymenu_panelapplet.so
W: tastymenu undefined-non-weak-symbol /usr/lib/tastymenu_panelapplet.so 
_ZTI8KService
W: tastymenu undefined-non-weak-symbol /usr/lib/tastymenu_panelapplet.so 
_ZTI13KServiceGroup
W: tastymenu undefined-non-weak-symbol /usr/lib/tastymenu_panelapplet.so 
_ZN8KService20serviceByDesktopPathERK7QString
W: tastymenu undefined-non-weak-symbol /usr/lib/tastymenu_panelapplet.so 
_ZN13KServiceGroup7entriesEbbbb
W: tastymenu undefined-non-weak-symbol /usr/lib/tastymenu_panelapplet.so 
_ZN9KDirWatch7addFileERK7QString
W: tastymenu undefined-non-weak-symbol /usr/lib/tastymenu_panelapplet.so 
_ZN4KRun10runCommandE7QString
W: tastymenu undefined-non-weak-symbol /usr/lib/tastymenu_panelapplet.so 
_ZNK9KFileItem4timeEjRb
W: tastymenu undefined-non-weak-symbol /usr/lib/tastymenu_panelapplet.so 
_ZN13KServiceGroup4rootEv
W: tastymenu undefined-non-weak-symbol /usr/lib/tastymenu_panelapplet.so 
_ZN13KServiceGroup5groupERK7QString
W: tastymenu undefined-non-weak-symbol /usr/lib/tastymenu_panelapplet.so 
_ZN15KRecentDocument15recentDocumentsEv
W: tastymenu undefined-non-weak-symbol /usr/lib/tastymenu_panelapplet.so 
_ZN13KServiceGroup10childCountEv
W: tastymenu undefined-non-weak-symbol /usr/lib/tastymenu_panelapplet.so 
_ZN10KDirListerC1Eb
W: tastymenu undefined-non-weak-symbol /usr/lib/tastymenu_panelapplet.so 
_ZN11KIconButtonC1EP7QWidgetPKc
W: tastymenu undefined-non-weak-symbol /usr/lib/tastymenu_panelapplet.so 
_ZN18KDEDesktopMimeType3runERK4KURLb
W: tastymenu undefined-non-weak-symbol /usr/lib/tastymenu_panelapplet.so 
_ZNK8KService6menuIdEv
W: tastymenu undefined-non-weak-symbol /usr/lib/tastymenu_panelapplet.so 
_ZNK8KService6pixmapEN5KIcon5GroupEiiP7QString
W: tastymenu undefined-non-weak-symbol /usr/lib/tastymenu_panelapplet.so 
_ZN9KDirWatchC1EP7QObjectPKc
W: tastymenu 
unused-direct-shlib-dependency /usr/lib/tastymenu_panelapplet.so /lib/libm.so.6

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.