[Bug 230710] Review Request: boolstuff - Disjunctive Normal Form boolean expression library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: boolstuff -  Disjunctive Normal Form boolean expression library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230710


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium

mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review?




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-04-29 13:34 EST -------
For 0.1.10-1:

? Subpackages
  - Please justify to split booldnf "subpackage" from
    boolstuff "main" package. Multilib effect or something?
    ( I don't know about multilib issue well)
    Usually splitting packages only addes complexity and
    confusion.

    Also, if you still want to split booldnf package, please
    reconsider the name of main package (usually, these
    type of package should be named as "-libs").

* Timestamps
  - This software installs some files which are not modified
    during build stage (e.g. header files, man files) 
    and keeping timestamps on these files is recommended.
    For this package, the following method works.
-------------------------------------------------------------------
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="%{__install} -p"
docdir=%{_datadir}/tmpdocdir
-------------------------------------------------------------------

? File entry
-------------------------------------------------------------------
/usr/include/boolstuff-0.1/boolstuff/BoolExpr.cpp
-------------------------------------------------------------------
  - Why is this file needed? (well, actually this file is called from
    BoolExpr.h, however is it correct?)

? documentation
  - For -devel subpackage:
-------------------------------------------------------------------
%doc examples/example.cpp examples/test-booldnf.pl examples/non-string-nodes.cpp
-------------------------------------------------------------------
    - Any reason you want to remove example/ directory?

===================================================================
!!
   I would appreciate it if you would review any of my ruby modules
   related review requests
   (bug 237380 and bug 237379 , both needed by alexandria < bug 237382 >
    bug 237381 is being reviewed by Chris Weyl)


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.