[Bug 237739] Review Request: perl-File-Modified - Checks intelligently if files have changed

bugzilla at redhat.com bugzilla at redhat.com
Mon Apr 30 16:59:25 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-File-Modified - Checks intelligently if files have changed
Alias: perl-File-Modified

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=237739





------- Additional Comments From bjohnson at symetrix.com  2007-04-30 12:59 EST -------
I love it ;)

+ find . -type f -name .cvsignore -exec rm -v '{}' ';'
removed `./.cvsignore'
removed `./t/.cvsignore'

...

+ /usr/bin/perl Makefile.PL INSTALLDIRS=vendor
Checking if your kit is complete...
Warning: the following files are missing in your kit:
        .cvsignore
        t/.cvsignore
Please inform the author.
Writing Makefile for File::Modified


Just sed those out of the MANIFEST as well.


Also, I see it's still skipping two of the tests:

+ make test
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
t/test....ok
        2/44 skipped: Digest:: is installed
All tests successful, 2 subtests skipped.
Files=1, Tests=44,  3 wallclock secs ( 0.37 cusr +  0.04 csys =  0.41 CPU)

I didn't look at the actuals skipped tests, but if it's indicating that it
doesn't need to run the test because perl(Digest) is installed (and the tests
are irrelevent when perl(Digest) is present), then that should be noted in the
spec file near %check.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list