[Bug 239385] Review Request: peless - Text Browser

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: peless - Text Browser


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239385





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-08-01 11:29 EST -------
* for %find_lang:
(In reply to comment #17)
> However, there are 
> currently 0 translations.  
> Should the .spec file have a %find_lang line?
  - Should NOT.

Two points.
* desktop file name
--------------------------------------------------------
mv ${RPM_BUILD_ROOT}%{_datadir}/applications/fedora-%{name}.desktop
${RPM_BUILD_ROOT}%{_datadir}/applications/%{name}.desktop
--------------------------------------------------------
  - Remove this line. i.e. the corresponding %file entry should be
    %{_datadir}/applications/fedora-%{name}.desktop .

* macros in %changelog
  - Now you can see in the changelong %configure is expanded.
    To avoid this, use %% in %changelog, i.e.
---------------------------------------------------------
%changelog
<snip>
- by removing it from --with-dtcat parameter to %%configure
---------------------------------------------------------

Still I am waiting for your new request or your pre-review of
other persons' review requests.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.