[Bug 249235] Review Request: pidgin-knotify - KNotify plugin for Pidgin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pidgin-knotify - KNotify plugin for Pidgin


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249235





------- Additional Comments From kevin at tummy.com  2007-08-05 23:52 EST -------
1. looks good. ok. 
2. looks good. ok. 
3. looks good. ok. 
4. looks good. ok. 
5. It still doesn't build on x86_64, but for a different reason: 
error: Installed (but unpackaged) file(s) found:
   /usr/lib/pidgin/knotify-plugin.so

Your patch has a hard coded /usr/lib in it. 

Looking at the compile options you should patch it to use rpm's normal optflags
if at all possible. 


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.