[Bug 248778] Review Request: gtkperf - Test GTK+ performance

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtkperf - Test GTK+ performance


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248778


patrice.bouchand.fedora at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |ASSIGNED
               Flag|needinfo?(patrice.bouchand.f|
                   |edora at gmail.com)            |




------- Additional Comments From patrice.bouchand.fedora at gmail.com  2007-08-07 07:11 EST -------
> * For sourceforge source, please refert to the section "Sourceforge.net" of
>   http://fedoraproject.org/wiki/Packaging/SourceURL

Change source path to
http://downloads.sourceforge.net/%{name}/%{name}_%{version}.tar.gz

> * Please follow the fedora usage of build root
>   (section: "BuildRoot tag" of
>    http://fedoraproject.org/wiki/Packaging/Guidelines )

Change  BuildRoot to %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
Use only %{buildroot} now (no more mixed with $RPM_BUILD_ROOT)

> * export CFLAGS="%{optflags}"
>   This is not needed as %configure sets it (please check what %configure
>   actually does by "rpm --eval %configure")

This has been removed. It is implicitly done by %configure.

> * Please set vendor id for desktop file (the section "desktop-file-install usage"
>   of http://fedoraproject.org/wiki/Packaging/Guidelines )

vendor Id set to fedora.

> * We now recommend %defattr(-,root,root,-)

Done.

> * rebuild failed. At least desktop-file-utils is missing from
>   BuildRequires.
>   http://koji.fedoraproject.org/koji/taskinfo?taskID=80492

Add BuildRequires:  desktop-file-utils

The new files:
Spec URL: http://patrice.bouchand.free.fr/rpm/gtkperf.spec
SRPM URL: http://patrice.bouchand.free.fr/rpm/gtkperf-0.40-4.fc7.src.rpm
    
     Thanks for you time.

           Patrice


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.