[Bug 248301] Review Request: lzma - lzma compression tools

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: lzma - lzma compression tools


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248301





------- Additional Comments From patrice.bouchand.fedora at gmail.com  2007-08-07 10:49 EST -------
>   - Well, -libs package is also licensed under LGPL and
>     it is more proper that LICENSE.LIB be owned by -libs, not -devel
>     (or you can have LICENSE.LIB owned by both -libs and -devel).

COPYING.LIB has been moved to -libs package.
 
>      For this package you can disable static link against liblzmadec.so
>      by passing "--diable-static" to configure. You also have to kill
>      unneeded rpath. 

Done. I checked it using ldd and chrpath.

>   - The reason I said so is because your -4 spec file had
> ---------------------------------------------------------
> Requires:       %{name} = %{version}
> ---------------------------------------------------------
>     for -devel package. However actually -devel package does not
>     require main package so you can remove the line.

Done.
 
> Then another issues are:
> * Source
>   - The newest seems to be beta5.

SRPM use the latest release now.
 
>     As far as I checked this source code,
>     - -libs and -devel package should be tagged as "LGPLv2+"
>       (this means that License field in spec file
>        should be tagged as "LGPLv2+")

License has been set to LGPLv2+ for -libs and -devel.

>     - For main package, I cannot find the phrase "and any later" on
>       LzmaDecode.c so I guess this code is licensed under strict LGPL
>       version 2.
>       However (according to the license matrix) LGPLv2 can be
>       relicensed to GPLv2+ (GPL version 2 and any later), and other
>       parts are licensed under LGPLv2+ and GPLv2+,
>       so the main package can be tagged with "GPLv2+".  

License has been set to GPLv2+ for main package.

 * -devel package still has %defattr(-,root,root)

Sorry, I think it's ok now.

The new files:

Spec URL: http://patrice.bouchand.free.fr/rpm/lzma.spec
SRPM URL: http://patrice.bouchand.free.fr/rpm/lzma-4.32.0-0.6.beta5.fc7.src.rpm

    Thanks

         Patrice



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.