[Bug 251110] Review Request: perl-IPC-RUN3 - Run a subprocess in batch mode

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-IPC-RUN3 -  Run a subprocess in batch mode


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=251110


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2007-08-07 12:07 EST -------
rpmlint complains about the license:
  W: perl-IPC-Run3 invalid-license GPL
  W: perl-IPC-Run3 invalid-license Artistic
"GPL" should be "GPL+" since the LICENSE file explicitly says "any version".  I
have no idea why rpmlint complains about Artistic but it should obviously be
ignored here.

Otherwise there are a couple of minor issues with this package; it would be nice
if they were fixed or documented but I don't think are blockers:

It looks like it has an executable (run3profpp) which could be installed to
/usr/bin, but it's your decision as to whether to install it or not.

One test is skipped because Test::Pod is not installed.  Generally you'd want
complete test coverage, but I don't think it's a blocker in this case as it's
only some checks of the documentation.  Still, I'd urge you to add the build
dependency so the whole test suite can run.

Since there are other tickets blocked on this one, I'll go ahead and approve
this and you can fix the license tag when you check in.

Review:
* source files match upstream:
   da7a829997fb8c2bf9389b016848aabb1ee946f6a57d69d492b74f31593392f2  
   IPC-Run3-0.037.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
X license field needs "GPL+" bit.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper (would use perl(Test::Pod) for better test coverage)
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
X rpmlint has a valid complaint (license tag)
* final provides and requires are sane:
   perl(IPC::Run3) = 0.037
   perl(IPC::Run3::ProfArrayBuffer) = 0.030
   perl(IPC::Run3::ProfLogReader) = 0.030
   perl(IPC::Run3::ProfLogger) = 0.030
   perl(IPC::Run3::ProfPP) = 0.000
   perl(IPC::Run3::ProfReporter) = 0.000
   perl-IPC-Run3 = 0.037-1.fc8
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(Carp)
   perl(Exporter)
   perl(File::Temp)
   perl(IPC::Run3::ProfReporter)
   perl(POSIX)
   perl(constant)
   perl(strict)
   perl(warnings)
* %check is present and all tests pass:
   All tests successful, 1 test skipped.
   Files=11, Tests=54,  0 wallclock secs ( 0.51 cusr +  0.42 csys =  0.93 CPU)
   The skipped test is due to a missing Test::Pod dependency and is not critical
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED; just change GPL to GPL+ in the license tag.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.