[Bug 247513] Review Request: junit4 - java regression testing framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: junit4 - java regression testing framework


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247513





------- Additional Comments From bkonrath at redhat.com  2007-08-07 15:24 EST -------
New Files:

http://bagu.org/eclipse/junit4-4.3.1-1jpp.1.fc8.src.rpm
http://bagu.org/eclipse/junit4.spec

(In reply to comment #5)
> Thanks and sorry for the delay. I dont think you need to bump the release for
> this, but whatever :)

Ok, I put it back to 1.

> This is probably really nit-picky but I recommend using the 
> %define _with_gcj_support 0 up top to disable aot compilation for the moment if
> you want to. So you wont have to comment out ownership under the %{_libdir}/gcj
> etc. and once the bugs in gcj are fixed simply switching the gcj_support thing
> would do. 

The macro wasn't working so I just set gcj_support to 0 manually.

> Also, it seems that the version of spec-gcj-convert used to build the
> spec has bugs:
> %postun
> %if %{gcj_support}
> ...
> %endif
> 
> while it really should be:
> %if %{gcj_support}
> %postun
> ...
> %endif
> 
> This leaves empty script sections when gcj support is disabled by default -
> which is the case in jpackage and currently, due to the said gcj bug for Fedora
> as well.

Fixed.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.