[Bug 249992] Review Request: glglobe - OpenGl Globe - Earth simulation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: glglobe - OpenGl Globe - Earth simulation


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249992





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-08-09 14:16 EST -------
I have not checked -4 spec/srpm, for now just answering your
comment:

(In reply to comment #9)
> - mod .desktop category to Education, although some or all of the {Education,
> Graphics, DataVisualization, Geography, Amusement, ImageProcessing } might fit ?
  - IMO only one Category "Education" is enough.

> > desktop-file-install --vendor fedora --delete-original \
> When I followed other packages as an example, it seems that --delete-original
> was normal. Is this a changed packaging standard ?
  - You don't have to (and must not) delete the original SOURCEx.
    The reason you had to use --delete-original was if you didn't
    use it, i.e.
--------------------------------------------------
install -p -m 0644 %{SOURCE4} %{buildroot}%{_datadir}/applications
desktop-file-install --vendor fedora  \
  --dir %{buildroot}%{_datadir}/applications           \
  --add-category X-Red-Hat-Base                        \
  %{buildroot}%{_datadir}/applications/glglobe.desktop
----------------------------------------------------
    This result in leaving 2 desktop files named "glglobe.desktop"
    and "fedora-glglobe.desktop" under %{buildroot}%{_datadir}/applications .
    So in this usage --delete-original was actually needed.

    By the new usage (written below:)
----------------------------------------------------
desktop-file-install --vendor fedora \
    --dir %{buildroot}%{_datadir}/applications %{SOURCE4}
----------------------------------------------------
    Only one desktop file named "fedora-glglobe.desktop" is created
    under %{buildroot}%{_datadir}/applications so it is already
    okay. And you don't have to (and must not) delete the original
    SOURCE4 file.
 
> A query: is it worth testing in fc6 and fdevel {my testing has been in f7}?
- If you have FC6 or rawhide machine and you can test on them,
  of course it is appreciated.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.