[Bug 250467] Review Request: rainbow - The service component of the OLPC Bitfrost security platform

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: rainbow - The service component of the OLPC Bitfrost security platform


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250467


bdpepple at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From bdpepple at gmail.com  2007-08-12 09:43 EST -------
MD5Sums:
9a2c828bf6b91aa2f343fc88b3ab2eab  rainbow-20070731gitde262e.tar.bz2

Good:
* Source URL is canonical
* git source tarball verified
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* Buildroot has all required elements
* All directories are owned by this or other packages
* All necessary BuildRequires listed.
* Package build fine in Mock

Bad:
* rpmlint produces the following error, which should be easy to fix:
 E: rainbow non-standard-executable-perm /usr/sbin/rainbow 0744
 E: rainbow non-readable /etc/rainbow/rainbow.conf 0600
* You should use a macro for '/usr/sbin/rainbow'.  refer to
http://fedoraproject.org/wiki/Packaging/RPMMacros
* Does the package really need python-setuptools as a Require?

Minor:
* you can drop the sitearch variable from the spec, since it's unused.
* you can remove the CFLAGS from the build call, since it's a noarch package.

+1 approved, please review and fix the bad items before importing into CVS.  thanks.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.