[Bug 252046] Review Request: util-linux-ng (util-linux replacement)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: util-linux-ng (util-linux replacement)


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=252046





------- Additional Comments From mitr at redhat.com  2007-08-13 18:37 EST -------
Blockers:
* Licensing:
  -  "If (and only if) the source package includes the text of the license(s) in
     its own file, then that file, containing the text of the license(s) for the
     package, must be included as documentation."
  - Please update License: per Packaging/LicensingGuidelines
* BuildRoot value is invalid, see Packaging/Guidelines
* Inconsistent use of both BuildRoot and %{buildroot}
* Use %config(noreplace) - at least for 60-raw.rules, I'm not sure about the
  files in /etc/pam.d/

Possible improvements:
* Obsoletes: clock - seems to be pre-Fedora, can be removed IMHO.
  Same for timeconfig.
* mnt_test_sysinfo.c:74: warning: right shift count >= width of type
  on i386 - probably should be fixed upstream
* BuildRequires: sed is unnecessary

Questions:
* does floppy really need %makeinstall?
* why is the [ "%{_infodir}" != "%{_prefix}/info" ... ] section necessary?
* why is (gzip -9nf ${RPM_BUILD_ROOT}%{_infodir}/ipc.info) necessary?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.