[Bug 251529] Review Request: armacycles-ad - A lightcycle game in 3D

bugzilla at redhat.com bugzilla at redhat.com
Thu Aug 16 18:33:06 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: armacycles-ad - A lightcycle game in 3D


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=251529





------- Additional Comments From j.w.r.degoede at hhs.nl  2007-08-16 14:33 EST -------
Created an attachment (id=161672)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=161672&action=view)
Updated specfile

(In reply to comment #9)
> Ok, I've addressed most of #4-#5, and part of #6.  Not sure how to rid my
self
> of /usr/etc.
> 

Attached is a specfile which fixes /usr/etc and a couple of other things. I
hope you don't mind me doing it this way, thats easier then typing a long list
of Must Fix items.

Notice that rpmlint still complains about some none executable scripts /
scripts without shebang, these need to be fixed too, I wonder if we need to
ship these scripts at all, they seam maintainer oriented and are probably not
needed to play the game.

> Also, for the language, resource and script bits that are duplicated, should
I
> just put them in /usr/share/armacycles-ad-common/language||resource||scripts
and
> put symlinks in the main and -dedicated packages?
> 

Ah, I thought the 2 packages used the same dir under /usr/share, as it turns
out they both have there own dir, its ok to leave things as as.

Last, please remove Version=1.0 from the .desktop, .desktop files should not
contain a Version= field. An also please remove "Applcation;" from the
Categories field in the .desktop file, thats wrong too.


p.s.

Great job in getting the trademark issue cleared, it will be good to have this
in Fedora!


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the package-review mailing list