[Bug 219889] Review Request: bootchart - a utility for profiling the boot process

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bootchart - a utility for profiling the boot process


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219889


ajackson at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review-              |fedora-review?




------- Additional Comments From ajackson at redhat.com  2007-08-16 17:07 EST -------
(In reply to comment #9)

> * Please choose one of GPL+, GPLv2, GPLv2+, GPLv3, GPLv3+.  See various mailing
> list threads about it.  Also, I'll note that one of the files you install
> (/usr/share/doc/bootchart-0.9/LICENSE.compress.txt) mentions the Apache License.
>  Might want to figure out what's up with that.

Everything looks to be v2+, but then also links against
org.apache.commons.compress.tar, which is Apache 2.0.  So I'm just claiming it's
 GPLv3+ for now.  I'll ask upstream what they really mean though.

> * System Environment/Base seems to be the right group for the logger

Done.

> * Preserve your file timestamps by using the -p flag to install(1)

Done.

> * There's a new preferred buildroot of the day, it appears, though you're using
> the second-best version of it.  Just figured I'd point that out since it
humors me.

Done.

> * I'll assume this builds under mock.  If it doesn't you'll find out when you
> try to build into koji.

Yep.

> * Also, is this package really useful without the logger subpackage?  Might
> consider killing the subpackage.

Yeah, it's sort of backwards.  The core package is the renderer, the logger is
the init wrapper.  I could do it as bootchart / bootchart-renderer I guess?

The intent is to just have bootchart-logger always active, and let people either
render stuff themselves or go to the web UI for it on bootchart.org.

New packages and spec at the same URL as before.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.