[Bug 252418] Review Request: gtk-vnc - a VNC viewer widget for GTK

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtk-vnc - a VNC viewer widget for GTK


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=252418


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2007-08-16 23:29 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and RPM.
+ source files match upstream.
f0781695819bd00d5ba160205723a3b4  gtk-vnc-0.1.0.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ gtk-vnc-1.0.pc file present.
+ -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ ldconfig scriptlets are used.
+ gtk-vnc-0.1.0-3.fc8 rpm
=>Provides: libgtk-vnc-1.0.so.0
=>Requires: libatk-1.0.so.0 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1)
libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.2) libc.so.6(GLIBC_2.3.4)
libc.so.6(GLIBC_2.4) libcairo.so.2 libdl.so.2 libgdk-x11-2.0.so.0
libgdk_pixbuf-2.0.so.0 libglib-2.0.so.0 libgmodule-2.0.so.0 libgnutls.so.13
libgnutls.so.13(GNUTLS_1_3) libgobject-2.0.so.0 libgtk-vnc-1.0.so.0
libgtk-x11-2.0.so.0 libpango-1.0.so.0 libpangocairo-1.0.so.0 rtld(GNU_HASH)
+ gtk-vnc-devel-0.1.0-3.fc8 rpm
=>Requires: gnutls-devel gtk-vnc = 0.1.0 gtk2-devel libgtk-vnc-1.0.so.0
pkgconfig pygtk2-devel
+ gtk-vnc-python-0.1.0-3.fc8 rpm
=>Provides: gtkvnc.so
=>Requires: gtk-vnc = 0.1.0 libc.so.6 libc.so.6(GLIBC_2.0)
libc.so.6(GLIBC_2.1.3) libglib-2.0.so.0 libgobject-2.0.so.0 libgtk-vnc-1.0.so.0
python(abi) = 2.5 rtld(GNU_HASH)

+ Not a GUI app.

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.