[Bug 253355] Review Request: twill - A simple scripting language for Web browsing

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: twill - A simple scripting language for Web browsing


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=253355





------- Additional Comments From opensource at till.name  2007-08-18 15:13 EST -------
(In reply to comment #2)

> I fixed almost everything that you mentioned, Till.  The only thing that is a
> bit questionable is the mechanize requirement.  It looks as if twill ships it's
> own mechanize code, so I don't think we need to worry about pulling our own in.
>  What do you think?

>From the twill hp:
| pyparsing, mechanize, and BeautifulSoup are included with twill for convenience,
| but are under their own licenses.

Fedora contains a newer version of pyparsing, the same version of mechanize and
an older version of clientform (also in devel, so if there is none, imho a bug
should be filed).  I cannot find BeatifulSoup being included in twill and
subproccess is included in python-2.5 .

Do you know how setup.py works? The best approach would be to patch it in a way
that it accepts an argument, e.g. "--exclude-other-packages", that makes the
other packages not being installed and submit this upstream. Otherwise it seems
a simple patch to setup.py is enough to make these packages not being installed.
With these being installed afaik you have to add each license to the License Tag
and also it may violate the Guidelines, because it is imho the same case with
binary packages that contain their own copy of a library.

I also noticed that twill contains some tests, maybe these should be run in
%check, but I do not know how to do this, but I saw someone mentioning this in
another review. But he wrote that there are no tests, so %check is not needed. ;-)

All the changes look good, btw.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.