[Bug 250210] Review Request: gimp-resynthesizer - Gimp plugin for texture synthesis

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gimp-resynthesizer - Gimp plugin for texture synthesis


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250210





------- Additional Comments From ewan at macmahon.me.uk  2007-08-19 18:03 EST -------
Hi,
Thanks for the comments; taking them in order:
- The pointless comment's gone,
- License field set to GPLv2+ (the COPYING file is indeed GPLv2, but the 
header on the actual code specifies the 'or any later version' text),
- According to: 
http://fedoraproject.org/wiki/Packaging/Guidelines#head-76294f12c6b481792eb001ba9763d95e2792e825 
the mktemp based build root I've used is now the most preferred option - I'm 
happy to change it if I'm misinterpreting the guidelines,
- RPM variable/macro style; that was a leftover from testing something, not 
sure how it got left in. It's all macro style now, that also removes the 
duplicate.
- CFLAGS are now set to %{optflags}, this overrides the defaults in the 
Makefile,
- I can't reliably reproduce the build errors; I've had different errors (and 
some successful builds) at different times today with identical input SRPMS, 
including most recently:

>  Error: Missing Dependency: zlib = 1.2.3-13.fc8 is needed by package 
zlib-devel
>  Error performing yum command: /usr/sbin/mock-helper 
yum --installroot /var/lib/mock/fedora-development-x86_64/root 
install  'gimp-devel' 'gimp'

So it looks like there may be some churn occurring in the dependencies at the 
moment. It does build cleanly for F7, and has just built for -devel.

Revised packages (built with mock for fedora-devel) containing the fixes so 
far are here:
SPEC (same url): 
http://www.macmahon.me.uk/linux/fedora/SPECS/gimp-resynthesizer.spec
SRPM: 
http://www.macmahon.me.uk/linux/fedora/SRPMS/gimp-resynthesizer-0.15-2.fc8.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.