[Bug 234612] Review Request: Ice - The Internet Communications Engine (Object middleware)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Ice - The Internet Communications Engine (Object middleware)


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234612


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review?




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-08-20 11:14 EST -------
For 3.2.1-2:

1. First, for spec file:
1-1: Description stage
A: ruby-libs dependency
   - This package has "BuildRequires: ruby-libs" and
     -ruby subpackage has "Requires: ruby(abi) = 1.8"

     For consistency (i.e. to avoid that this package is
     rebuild against ruby 1.9), IMO "BuildRequires: ruby-libs"
     should be replaced with "ruby(abi) = 1.8".

B. Release number specific dependency
   - Usually the dependency between main package and subpackages
     MUST be EVR (epoch-version-release) specific.
     i.e. for example -server subpackage must have:
--------------------------------------------------
Requires: ice = %{version}-%{release}
--------------------------------------------------

C. Dependency between subpackages
   - Please check if this is correct. For example,
     is the following correct?
     - -java subpackage does not require main package
     - -java-devel subpackage does not require -java subpackage
     - -csharp subpackage does not require main package

D. naming
   - Usually foo-devel package should have the corresponding
     package named foo.
     IMO -cxx-devel subpackage should just be named as
     "ice-devel".

E. pkgconfig dependency
   - Packages which contains pkgconfig .pc files must have
     "Requires: pkgconfig"

1-2: %files and scriptlets
A. User/group registry
   - Please refer to:
     http://fedoraproject.org/wiki/Packaging/UsersAndGroups

B. ldconfig
   - It does not seem that -c++-devel subpackage should call ldconfig
     on %post and %postun

C. Directory ownership issue
   - The following directories are not owned by any packages
-----------------------------------------------------
%{python_sitelib}/Ice/*/
-----------------------------------------------------

2. rpmlint complaint
A. script-without-shebang
-----------------------------------------------------
E: ice script-without-shebang /usr/share/Ice-3.2.1/slice/Freeze/Connection.ice
E: ice script-without-shebang /usr/share/Ice-3.2.1/slice/IceGrid/FileParser.ice
E: ice script-without-shebang /usr/share/Ice-3.2.1/slice/Freeze/Transaction.ice
E: ice script-without-shebang
/usr/share/Ice-3.2.1/slice/Glacier2/PermissionsVerifierF.ice
-----------------------------------------------------
   - Why do these scripts have executable permission?

B. non-standard-group
-----------------------------------------------------
W: ice-csharp non-standard-group System Environment/Libaries
------------------------------------------------------
   - Please fix typo

C. License tags
------------------------------------------------------
W: ice invalid-license GPL
------------------------------------------------------
   - License tag policy changed. Please fix according to:
     http://fedoraproject.org/wiki/Licensing
     http://fedoraproject.org/wiki/Packaging/LicensingGuidelines

D. macro-in-%changelog
-------------------------------------------------------
W: ice macro-in-%changelog ifnarch
W: ice macro-in-%changelog _lib
W: ice macro-in-%changelog _sbindir
W: ice macro-in-%changelog _libdir
W: ice macro-in-%changelog _prefix
--------------------------------------------------------
   - Use %% in the %changelog to prevent macros from being
     expanded. For example:
--------------------------------------------------------
* Wed Aug  1 2007 Mary Ellen Foster <mefoster at gmail.com> 3.2.0-7
- Fixed arch-specific issues:
  - %%ifnarch ppc64 in a lot of places; it doesn't have db4-java or mono-core, so 
    no Java or CSharp packages
  - Replaced one literal "lib" with %%{_lib}
--------------------------------------------------------

3. build log check
  - Still some compilation does not honor fedora specific compilation
    flags
    (build log also available under
     http://koji.fedoraproject.org/scratch/mtasaka/task_110075/ )
---------------------------------------------------------
   163  make[2]: Leaving directory `/builddir/build/BUILD/Ice-3.2.1/src/IceUtil'
   164  making all in icecpp
   165  make[2]: Entering directory `/builddir/build/BUILD/Ice-3.2.1/src/icecpp'
   166  cc -c -I../../include  -O2 -I. -DPREFIX=\"\" cccp.c
   167  cc -c -I../../include  -O2 -I. -DPREFIX=\"\" cexp.c
   168  cc -c -I../../include  -O2 -I. -DPREFIX=\"\" prefix.c
   169  rm -f ../../bin/icecpp
   170  cc -O2 -I. -DPREFIX=\"\" -o ../../bin/icecpp cccp.o cexp.o prefix.o
   171  make[2]: Leaving directory `/builddir/build/BUILD/Ice-3.2.1/src/icecpp'
----------------------------------------------------------

4. All source codes check (especially license issue check)
  - Well, this is extremely hard.. Actually there are (in total)
    10448 files (the most number in the packages I have reviewed...)

    I may skip this check during review, however if I find any issues
    I will report later.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.