[Bug 251545] Review Request: setroubleshoot-plugins - analysis plugins for setroubleshoot

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: setroubleshoot-plugins - analysis plugins for setroubleshoot


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=251545


tmraz at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tmraz at redhat.com  2007-08-21 12:29 EST -------
(In reply to comment #2)
> Thank you for your review Tomas, its very much appreciated.
> 
> New files have been loaded at the above URL (sorry, at the moment I don't think
> FedoraProject will allow puting the files there, at least that used to be case,
> perhaps it's changed)
I think that you can simply attach the .tar.gz files to the Trac wiki of your
project. It's not ideal but it works - like here:
https://hosted.fedoraproject.org/projects/vixie-cron/

Also the URL field should point to the project pages rather than www.redhat.com.

> All the above issues have been addressed, except one. The permissions on the
> spec file are still 0600 and that seems to be the result of using rpmbuild in
> tar file mode. The permissions on the spec file in the tar file is 0664. If you
> use rpmbuld to create the srpm in non-tar file mode the spec file is 0644, but
> if you use rpmbuild to create the spec file in tar file mode it appears to
> change the permissions from 0644 in the tar file to 0600, go figure, I don't
> know why. Other spec files have 0600 and it hasn't created a problem yet. 
That's nothing critical as when you'll import the spec file with right
permissions into packages CVS the perms should be OK in the rpms built by koji.

rpmlint output:
rpmlint -v RPMS/noarch/setroubleshoot-plugins-1.10.0-1.fc8.noarch.rpm 
I: setroubleshoot-plugins checking

rpmlint -v SRPMS/setroubleshoot-plugins-1.10.0-1.fc8.src.rpm 
I: setroubleshoot-plugins checking
W: setroubleshoot-plugins strange-permission setroubleshoot-plugins.spec 0600
OK - see above

As I wrote above - perhaps you have overlooked that: In the %post - the
dbus-send output+stderr probably should be redirected to /dev/null and also the
command safeguarded for non-zero exit status by '||:'

Otherwise it's OK so APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.