[Bug 251071] Review Request: StatelessServer - Server for Stateless Clients

bugzilla at redhat.com bugzilla at redhat.com
Wed Aug 22 01:08:32 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: StatelessServer - Server for Stateless Clients


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=251071





------- Additional Comments From dlutter at redhat.com  2007-08-21 21:08 EST -------
Not a full review, but seeing such a large %post script makes me very
uncomfortable. For starters, what is going to happen when people update to a
newer version of the package (at least for lokkit, you append to its config file
every time) ... restarting services from %post is very bad, since it breaks
installing the package into buildroots (mock)

Please turn the %post script into a file that gets installed by the package and
has to be run manually. (You could of course turn this into a puppet manifest,
but having stateless-server manage itself through puppet seems a little too clever)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the package-review mailing list