[Bug 249352] Review Request: popt - C library for parsing command line parameters

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: popt - C library for parsing command line parameters


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249352


opensource at till.name changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |opensource at till.name
               Flag|                            |fedora-review+




------- Additional Comments From opensource at till.name  2007-08-22 07:42 EST -------
graphviz (or something else that provides dot) is missing in the BuildRequires,
without it errors like this are shown:

sh: dot: command not found
Problems running dot: exit code=127, command='dot',
Arguments='"poptint_8h__dep__incl.dot" -Tpng -o "poptint_8h__dep__incl.png"'

Review:

- rpmlint: ok (this is with BR on graphviz)
E: popt-devel zero-length /usr/share/doc/popt-devel-1.12/html/popt_8h__incl.map
This is created by doxygen, imho there is no need to remove it manually.
W: popt-static no-documentation
This is no problem, too.

- naming: ok
- spec file readability: ok

- source: ok
f45290e9ac4b1cf209d0042eb6755543  /tmp/popt-1.12.tar.gz
f45290e9ac4b1cf209d0042eb6755543  popt-1.12.tar.gz

- mockbuild i386 F7: ok
- BuildRequires: NEEDSWORK (add graphviz)
- ldconfig scriptlets: ok
- Directory Ownership: ok
- %clean section: ok
- macro usage: ok
- doc: large api doc is in devel, ok
- devel subpackage with headers: ok
- static subpackage: ok
- .so file in -devel: ok
- subpackage requires: ok
- .la removed: ok
- correct %install
- license included: ok
- Buildroot: ok


Add graphviz to BR before you import the package and it is APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.