[Bug 254016] Review Request: rubygem-gem_plugin - plugin system based on rubygems

bugzilla at redhat.com bugzilla at redhat.com
Thu Aug 23 23:37:09 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: rubygem-gem_plugin - plugin system based on rubygems


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=254016





------- Additional Comments From dlutter at redhat.com  2007-08-23 19:37 EST -------
OK - Package name
OK - License info is accurate
OK - License tag is correct and licenses are approved
OK - Specfile name
OK - Specfile is legible
OK - No prebuilt binaries included
OK - BuildRoot value (one of the recommended values)
OK - PreReq not used
OK - Source md5sum matches upstream
OK - No hardcoded pathnames
OK - Package owns all the files it installs
OK - Package requires create needed unowned directories
OK - Package builds successfully on i386 and x86_64 (mock)
OK - BuildRequires sufficient
OK - File permissions set properly (except for rpmlint error below)
OK - Macro usage is consistent

OK - Package is named rubygem-%{gemname}
OK - Source points to full URL of gem
OK - Package version identical with gem version
OK - Package Requires and BuildRequires rubygems
OK - Package provides rubygem(%{gemname}) = %version
OK - Package requires gem dependencies correctly
OK - %prep and %build are empty
OK - %gemdir defined properly, and gem installed into it
OK - Package owns its directories under %gemdir
OK - No arch-specific content in %{gemdir}
OK - Package is noarch

FIX - License files are not installed as %doc
      Mark %{geminstdir}/{LICENSE,COPYING} as %doc

FIX - rpmlint complains 
   E: rubygem-gem_plugin script-without-shebang
/usr/lib/ruby/gems/1.8/gems/gem_plugin-0.2.2/bin/gpgen
  
      Omitting the chmod of %{buildroot}%{geminstdir}/bin/* should do the right
thing
    
FIX - Requires: rubygem(rake) can not be met since that's not packaged



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the package-review mailing list