[Bug 250240] Review Request: linkage - Lightweight bittorent client

bugzilla at redhat.com bugzilla at redhat.com
Fri Aug 24 07:57:59 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: linkage - Lightweight bittorent client


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250240





------- Additional Comments From denis at poolshark.org  2007-08-24 03:57 EST -------
Some more nitpicks :-)

- Patches are traditionally named something like
<name>-<version>-tag.patch, where version if the upstream version the
patch was generated from (and not necessarily that of the spec
itself). Could you rename the patch to "linkage-0.1.4-plugindir.patch" ?

- Exporting the '-Wl,--as-needed' option will not work, due to a
flaw/bug/feature in libtool (remember all compiler and linker flags
are processed by libtool) : it'll move the linker option at the end of
the command-line and that won't work (see discussions in the link I
posted above).

I used the following line after configure:

# clean unused-direct-shlib-dependencies
sed -i -e 's! -shared ! -Wl,--as-needed\0!g' libtool

- Also, you don't need to set CFLAGS and CXXFLAGS before calling make.


Review will be approved after these fixes.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the package-review mailing list