[Bug 250893] Review Request: audio-convert-mod - A simple audio file converter supporting many formats

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: audio-convert-mod - A simple audio file converter supporting many formats


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250893


jpmahowald at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |jpmahowald at gmail.com
               Flag|                            |fedora-review?




------- Additional Comments From jpmahowald at gmail.com  2007-08-24 10:36 EST -------
License: GPL is not sufficient, you have to specify which one, as per 
http://fedoraproject.org/wiki/Licensing

I notice source files specifying GPL 2 or later.


You have your python macro backwards: get_python_lib(1) is how the sitearch
macro is defined. Really it should be get_python_lib() for a noarch. However, in
the Makefile, it expands $(LIBDIR). I suggest fixing this to use python to PYMODDIR.

There is an uninstall script. Remove, rpm is going to manage this.


Does not use restricted code, rather calls programs if they exist. Good.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.