[Bug 234612] Review Request: Ice - The Internet Communications Engine (Object middleware)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Ice - The Internet Communications Engine (Object middleware)


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234612





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-08-24 13:19 EST -------
Well, I have not checked -5 in detail, however:

>From diff of -4 and -5:
-------------------------------------------------------
@@ -327,10 +350,8 @@
 done
 mkdir -p ${RPM_BUILD_ROOT}%{ruby_sitearch}/Ice
 mv $RPM_BUILD_ROOT/ruby/* ${RPM_BUILD_ROOT}%{ruby_sitearch}/Ice
-mkdir -p ${RPM_BUILD_ROOT}%{python_sitearch}/Ice
-mv ${RPM_BUILD_ROOT}/python/IcePy.so* ${RPM_BUILD_ROOT}%{python_sitearch}/Ice
 mkdir -p ${RPM_BUILD_ROOT}%{python_sitelib}/Ice
-cp -p %SOURCE7 $RPM_BUILD_ROOT%{python_sitelib}
+cp -p %{SOURCE7} $RPM_BUILD_ROOT%{python_sitelib}
 mv ${RPM_BUILD_ROOT}/python/* ${RPM_BUILD_ROOT}%{python_sitelib}/Ice
 
 mkdir -p ${RPM_BUILD_ROOT}%{_datadir}/Ice-%{version}
-----------------------------------------------------------------
Well, actually IcePy.so is arch-dependent binary and this
must be put under python_sitearch, not python_sitelib.

(In reply to comment #39)
> Note that, with the python %files changes, I get a spew of "file listed twice"
> errors because python_sitelib and python_sitearch are the same directory on my
> i386 machine,

Yes, this has always been a issue when both sitelib and sitearch are
needed. Perhaps the following will work.
-----------------------------------------------------
%files python
%defattr(644,root,root,755)
%ifarch x86_64 ppc64
%{python_sitearch}/Ice/
%endif
%{python_sitelib}/Ice/
%{python_sitelib}/%{name}.pth
------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.