[Bug 250970] Review Request: ivtv-firmware - Firmware for the PVR 250/350/150/500 model series

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ivtv-firmware - Firmware for the PVR 250/350/150/500 model series


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250970


kwizart at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |kwizart at gmail.com




------- Additional Comments From kwizart at gmail.com  2007-08-24 14:48 EST -------
So, found it !

We should probably block requirement at the bugzilla level
 (if it needs for exemple ivtv and perls scripts)
I've found ivtv but not perls scripts whereas they are still Required by ivtv
ivtv is here #250971

>From preliminaries comments :

1- Requirements: Check if it is necessay for the firmware to requires ivtv (or
ivtv to requires the firmware..)- then set the appropriate blocks in bugzilla

2- We should drop compats locations to only provides firmwares in /lib/firmware
for F7 -> devel

3- Buildroot: those are others values but the one choosen is acceptable also...
%(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

4- ivtv-firmware.spec is the name of the spec (this is the case from the src.rpm
so everything is right...)

5- Version field is wrong: 20070217 you be taken from a release tag. If we have
0 in a version tag, I think it is acceptable to have release tag not <1. This
leads to have:
epoch: 3
version: 0
release: 1.%{snapshoot}snap
3:0-1.20070217snap
Using this if upstream ever provides version 1.0 of the firmware or else, this
scheme will continue to work...

6- setup -n %{name}-%{version} is unneeded at this time, but it will more likely
have to be replaced by -n %{name}-%{snapshot}

7- /lib/firmware/v4l-cx2341x-init.mpg is also a requirement but is arch
independant and could benefit to be bundled from an arch independant package
instead of ivtv (which one is arch dependant) - Anyway as we shouldn't be
concerned by multilibs problems with ivtv, this shouldn't be really important...

8- mv *.fw %{buildroot}/lib/firmware/ - you should better use install -pm 0644
to prevent timestamp.

9- A license to allow redistribution of the firmware is missing from the
package... Theres is Licenses files from the firmware archive and they need to
be provided in the %doc directory.

I'm not abble to state if this license allow Fedora to redistribute the firmware
within an iso so users can uses ivtv "out of the box"...







-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.