[Bug 250971] Review Request: ivtv - An iTVC15/16 and CX23415/16 driver

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ivtv - An iTVC15/16 and CX23415/16 driver


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250971





------- Additional Comments From kwizart at gmail.com  2007-08-24 16:26 EST -------
mock build works but rpmlint show errors:

1- Same treatment as the firmware for Requires:
There is no perl scripts at this time to be reviewed at this time.
They need to be reviewed first...

2- License is now GPLv2 (not GPLv2+ ) this probably concern the kernel module
part... I haven't checked if the tools are concerned also... (we only care of
the tools actually)

3- We shouldn't provided a ivtv-devel for this, as kernel-headers should provide
it - which do not seems the case on a recent Fedora 7 kernel...Unless this
headers is made for tools...(I don't think so...)

4- make must honnor $RPM_OPT_FLAGS and %{?_smp_mflags} - you have to state why
you don't use them if it's don't work...

5- rpmlint error: E: ivtv only-non-binary-in-usr-lib
This concerns:  "install -p utils/ivtvfwextract.pl %{buildroot}%{_libdir}/ivtv/
see if they can be installed into %{_datadir}/ivtv/ or %{_bindir}/ if needed...
And it will probably need some perl dependency (but they could also be bring by
Perl-Video-ivtv and perl-Video-Frequencies )

6- symlinks have to be relative - But maybe those who produced the warning
aren't usefull anymore...
install -p v4l-cx2341x-init.mpg %{buildroot}/lib/modules/v4l-cx2341x-init.mpg
See if we can only install it in /lib/firmware

7- %{_libdir}/ivtv Directory ownership - 
It has to be %{_libdir}/ivtv/ if ever still used...





-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.