[Bug 202334] Review Request: jetty5 - The Jetty Webserver and Servlet Container

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: jetty5 - The Jetty Webserver and Servlet Container


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202334





------- Additional Comments From fitzsim at redhat.com  2007-08-24 17:07 EST -------
A few general comments while I wait for the mock build to complete:

- the license field is invalid according to new versions of rpmlint:

  $ rpmlint jetty5-5.1.12-1jpp.1.src.rpm
  W: jetty5 invalid-license Apache Software License

- I don't understand this comment:

  # we need a shell to be able to use su - later

  Can it be expanded to justify why /bin/sh instead of /sbin/nologin?

- I guess you'll add an entry in

  http://fedoraproject.org/wiki/PackageUserRegistry

  ?

- does fedora-usermgmt make preun user deletion OK?  I suppose the problems
  mentioned in

  http://fedoraproject.org/wiki/Packaging/UsersAndGroups

  are addressed by having the user registry + reserved address blocks?

- Maybe elaborate on why excluding the demo package is more secure and
  why you don't just delete those sections of the spec file.

- can the javadoc versioned directory be owned by the package?

- why the manual removal of %{homedir}/extra/ext/*.jar.  Can't they be
  owned by the package?  An explanatory comment would be good.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.