[Bug 253691] Review Request: java-1.7.0-icedtea - IcedTea runtime and development environments

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: java-1.7.0-icedtea - IcedTea runtime and development environments


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=253691





------- Additional Comments From fitzsim at redhat.com  2007-08-24 18:41 EST -------
(In reply to comment #20)
> MUST items:
> 
> ? package is named appropriately
>  - falls in line with JPackage JVM naming
>  - what's going to happen with the release tag when we hit 1.3?  Will it just
>    be 1.3%{?dist}?  Or will we always have the leading

No, the IcedTea release will continue to be encoded in the symbolic part of the
release string.  The 0.X prefix of the release string means that this is a
pre-release of what will become the 1.7.0.0 IcedTea release (derived from the
OpenJDK 1.7.0 final sources).  When 1.7.0.0 is released, the prefix will become
just X, representing a package revision of a final-release package.

> 0.NN.%{openjdkver}.%{icedtearelease}?
> OK it is legal for Fedora to distribute this
>  - assuming the assumptions about the three things listed in comment #14 are
>    okay

I talked to spot about this on IRC and he's fine with our rationale.

> NEEDS_FIXING verify source and patches 
>  - there's a "1.19" missing in the java-access-bridge URL

Fixed.

> ? are the rpath issues all sorted out in the comments above?

There weren't any rpath issues, according to the more-precise-than-rpmlint
checks in check-rpaths-worker.

> NEEDS_FIXING consider using cp -p to preserve timestamps
>  - can we add -p to the accessibility bridge copying?

I'm already using cp -a which implies -p.

> Remaining issues:
> - rmi cgi script - are we keeping it?

No, I removed it.

Spec URL: http://fedorapeople.org/~fitzsim/java-1.7.0-icedtea.spec
SRPM URL:
http://fedorapeople.org/~fitzsim/java-1.7.0-icedtea-1.7.0.0-0.13.b18.snapshot.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.