[Bug 254088] Review Request: b43-fwcutter - firmware cutter which outputs new format used by b43 drivers

bugzilla at redhat.com bugzilla at redhat.com
Sat Aug 25 19:33:36 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: b43-fwcutter - firmware cutter which outputs new format used by b43 drivers


https://bugzilla.redhat.com/show_bug.cgi?id=254088


adel.gadllah at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+




------- Additional Comments From adel.gadllah at gmail.com  2007-08-25 15:33 EST -------
Package Review:
===============
* md5sum matches upstream: 3f7fbf4f8dcd296c6d1b0d42eab0f9ac -> OK
---------------
* rpmlint output: none -> OK
---------------
* Package is named correctly -> OK
---------------
* uses macros consistently -> OK
---------------
* uses disttag -> OK
---------------
* License field is correct -> OK
---------------
* License is ok to ship and file is included -> OK
---------------
* BuildRequires are correct -> OK
---------------
* Ownership is set correctly -> OK
---------------
* scriplets are ok -> N/A
---------------
* buildroot is correct -> OK
---------------
* clean is present -> OK
---------------
* use $RPM_OPT_FLAGS -> ok
---------------
* desktop file installed correctly -> N/A
---------------
* file permissions are appropriate -> OK
---------------
* %docs are not needed for the package to work -> OK
---------------
* no devel package -> OK
---------------
* builds in mock -> OK
---------------
* no rpaths -> OK
===============
=> APPROVED
===============

---------------
NOTES:
Please add:
Obsoletes: bcm43xx-fwcutter 


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the package-review mailing list