[Bug 257181] Review Request: komparator - kompare/sync files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: komparator - kompare/sync files


https://bugzilla.redhat.com/show_bug.cgi?id=257181





------- Additional Comments From cgoorah at yahoo.com.au  2007-08-27 14:48 EST -------
#001: rpmlint issues
chitlesh(SPECS)[1]$rpmlint
/home/chitlesh/rpmbuild/RPMS/i386/komparator-0.6-1.fc7.i386.rpm
W: komparator dangling-relative-symlink /usr/share/doc/HTML/en/komparator/common
../common
W: komparator summary-ended-with-dot Kompare and merge two folders.
E: komparator no-changelogname-tag
W: komparator invalid-license GPL

a) dangling-relative-symlink
this can be ignored

b) summary-ended-with-dot
 remove the "." at the end of 
Summary:        Kompare and merge two folders.

c) no-changelogname-tag
Use the format :
http://fedoraproject.org/wiki/PackagingDrafts/Changelog

d) invalid-license GPL
in accordance to http://fedoraproject.org/wiki/Licensing, the license should be
GPLv2

#002:  invalid Desktop file when built for rawhide
+ popd
~/build/BUILD/komparator-0.6
+ mkdir -p /var/tmp/komparator-0.6-1.fc8-root-kojibuilder/usr/share/applications
+ desktop-file-install --vendor fedora --dir
/var/tmp/komparator-0.6-1.fc8-root-kojibuilder/usr/share/applications
--add-category Development --add-category X-Fedora --delete-original
/var/tmp/komparator-0.6-1.fc8-root-kojibuilder/usr/share/applnk/Utilities/komparator.desktop
/var/tmp/komparator-0.6-1.fc8-root-kojibuilder/usr/share/applications/fedora-komparator.desktop:
error: value "komparator %u %u" for key "Exec" in group "Desktop Entry" may
contain at most one
"-7670078101866630651717873087102748035497564288251167604132490569112640036869789081810181048277000760644432835593864709837114785281552514193246661663024168431575453304593947146415735068891226057192084963021678008061970004877307024271847785645658180104637099495058473739470073431290845100014481512884795867136.000000",
"4159892954", "0.000000" or "%U" field code
desktop-file-install created an invalid desktop file!
error: Bad exit status from /var/tmp/rpm-tmp.68670 (%install)

#003: build requires
kdebase-devel already requires kdelibs-devel.
Remove kdelibs-devel from the BuildRequires:

#004 Desktop file
a)    --add-category X-Fedora \ is not longer needed
b)    --add-category Development \ will add a duplicate menu entry on kmenu.
either use the catogory Utility or Development

#005: useless directory creation
You can remove 
mkdir -p $RPM_BUILD_ROOT%{_datadir}/applications
from the spec as desktop-file-creation does create the directory by itself.

#006 disabling rpath
add the following after the %configure macro
# disabling rpath
sed -i 's|^hardcode_libdir_flag_spec="\\${wl}--rpath
\\${wl}\\$libdir"|hardcode_libdir_flag_spec=""|g' libtool
sed -i 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.