[Bug 253813] Package Review: cjkunifonts (split from fonts-chinese)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Package Review: cjkunifonts (split from fonts-chinese)


https://bugzilla.redhat.com/show_bug.cgi?id=253813





------- Additional Comments From petersen at redhat.com  2007-08-29 03:55 EST -------
Here is the review:

+ rpmlint output:

W: cjkunifonts-ukai symlink-should-be-relative
/etc/X11/fontpath.d/cjkunifonts-ukai /usr/share/fonts/cjkunifonts-ukai
W: cjkunifonts-ukai obsolete-not-provided ttfonts-zh_CN
W: cjkunifonts-ukai obsolete-not-provided ttfonts-zh_TW
W: cjkunifonts-uming symlink-should-be-relative
/etc/X11/fontpath.d/cjkunifonts-uming /usr/share/fonts/cjkunifonts-uming
W: cjkunifonts-uming obsolete-not-provided ttfonts-zh_CN
W: cjkunifonts-uming obsolete-not-provided ttfonts-zh_TW

IMO these can be waived.

+ package name follows upstream project name
+ spec filename matches package name
+ packages two Chinese truetype fonts currently part of fonts-chinese
+ Arphic Public License is listed on Licensing page
+ license with translations included
+ spec files is legible
+ source files agree with debian upstream:
465b1350911f086a2021c36e039f79c8  ttf-arphic-ukai_0.1.20060928.orig.tar.gz
4f2e5a4ba4cf3ac01518ea211a89fdc1  ttf-arphic-uming_0.1.20060928.orig.tar.gz
+ package is noarch and builds correctly
+ build deps listed
+ owns own dirs
+ filelist looks correct
+ consistent macro usage

Need attention:
- should not own ghostscript/conf.d/ which belongs to ghostscript
- /usr/share/fonts/zh_*/TrueType/ seem to be empty in the rpm's
- and already mentioned ghostscript conf paths

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.