[Bug 228255] Review Request: grub2 - grub next generation tools

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: grub2 - grub next generation tools


https://bugzilla.redhat.com/show_bug.cgi?id=228255


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|Fedora Extras               |Fedora

opensource at till.name changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |opensource at till.name
OtherBugsDependingO|163776                      |
              nThis|                            |




------- Additional Comments From opensource at till.name  2007-08-29 07:18 EST -------
- GPL is not a valid license tag anymore:
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#head-f21ae23bf2f278444e2c385463cfa74a502396b8

- instead of /etc you should use %{_sysconfdir}
- maybe the file in /etc should be marked with %config, is it intended, that
they are not?
- Why is this update-grub_lib in %{_libdir}/grub and not in %{_libdir}/grub2?
Also in case it is intentional, the directory %{_libdir}/grub/ is not owned by
any package afaics.

- I guess %{_libdir}/grub2/* should be just %{_libdir}/grub2/ because otherwise
the directory %{_libdir}/grub2/ is not owned by any package.
- /etc/grub.d/ is also not owned by the package but created
- /boot/grub2 should be /boot/grub2/ imho to make it more obvious that it is an
directory
- the conditionals in %files can be simplified because there is a
"ExclusiveArch: i386 x86_64 ppc ppc64" tag and everything in the package for 
ppc(64), is also in the package for i386 and x86_64, so this should produce the
same rpms:

/sbin/grub2-emu
/sbin/grub2-install
/bin/grub2-mkimage
/boot/grub2/
%ifarch i386 x86_64
/sbin/grub2-mkdevicemap
/sbin/grub2-probe
/sbin/grub2-setup
%endif

- What do you mean with this comment: #All apart of update-grub2 tool?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.