[Bug 251824] Review Request: maniadrive - 3D stunt driving game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: maniadrive - 3D stunt driving game


https://bugzilla.redhat.com/show_bug.cgi?id=251824





------- Additional Comments From packages at amiga-hardware.com  2007-08-29 16:18 EST -------
* rpmlint:

W: maniadrive no-documentation
W: maniadrive-track-editor no-documentation
W: raydium no-documentation
W: raydium-devel no-documentation

Acceptable as docs are in the data package. See additional rpmlint warnings below.

* Package named correctly: Yes
* Patches named correctly: Yes
* Spec file named correctly: Yes
* Licence(s) acceptable: Yes
* Licence field matches: Yes
* Licence file installed: No
* Spec file in American English: Yes
* Source matches upstream: Yes
* Locales use %find_lang: N/A
* Contains %clean: Yes
* %install contain rm -rf %{buildroot} or similar: Yes
* Specfile legible: Yes
* Compiles and builds ok: NO (!!!!) See below
* Calls ldconfig in %post/%postun for shlibs: Yes
* Owns directories it creates: Yes
* Duplicate files: No
* Permissions set correctly: Yes
* Consistent macro use: Yes
* Separate -doc needed (for large docs): No
* %doc affects runtime: No
* Headers and libs in -devel: Yes
* .pc files in -devel: N/A
* .so in -devel: Yes
* -devel requires base: Yes
* Contains .la files: No
* Owns files it didn't create: No
* .desktop files included and installed correctly: Yes
* Filenames valid UTF8: Yes


1. The following BRs were added in order to get it to compile:

zlib-devel
curl-devel
libxml2-devel

They might not be strictly needed though, if you see point 4.


2. The description for Raydium reads poorly and has several spelling mistakes.
A suggested corrected version is below.

"Raydium is a game engine. It provides a set of functions which allow quick and
flexible games creation. There are a lot of other 3D/game engines (and some
are very complete, such as Ogre, Crystal Space, etc). Raydium does not try to
be as complex as these engines, but on the contrary is aiming at quick and
simple development."


3. Is this file useful to the end user? If so, would it be better placed in the
doc directory? It could give the rayphp location at the top for context. I'm not
familiar enough with the software to say either way.

/usr/share/raydium/rayphp/README


4. Additional rpmlint warnings.

W: raydium undefined-non-weak-symbol /usr/lib/libraydium-1.2.so sapi_globals
...
...
W: raydium unused-direct-shlib-dependency /usr/lib/libraydium-1.2.so
libphp5-5.2.3.so
W: raydium unused-direct-shlib-dependency /usr/lib/libraydium-1.2.so
/usr/lib/libvorbis.so.0
W: raydium unused-direct-shlib-dependency /usr/lib/libraydium-1.2.so
/usr/lib/libogg.so.0
W: raydium unused-direct-shlib-dependency /usr/lib/libraydium-1.2.so
/lib/libresolv.so.2
W: raydium unused-direct-shlib-dependency /usr/lib/libraydium-1.2.so
/lib/libcrypt.so.1
W: raydium unused-direct-shlib-dependency /usr/lib/libraydium-1.2.so /lib/libz.so.1
W: raydium unused-direct-shlib-dependency /usr/lib/libraydium-1.2.so
/usr/lib/libcurl.so.4
W: raydium unused-direct-shlib-dependency /usr/lib/libraydium-1.2.so
/usr/lib/libxml2.so.2

Obviously not a blocker, but you might want to check if these can be cleaned up
easily enough.


5. I read a packaging doc on the wiki that recommended against using macros in
patch names, but of course I can't find it now. :)


6. I think raydium-devel may need dependencies on
freealut-devel
libvorbis-devel

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.