[Bug 251020] Review Request: libflaim - Flaim Database Engine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libflaim - Flaim Database Engine


https://bugzilla.redhat.com/show_bug.cgi?id=251020





------- Additional Comments From snecklifter at gmail.com  2007-08-30 10:51 EST -------
(In reply to comment #1)

Thanks for the review Till.

> - static libraries should be in a -static package or not packaged at all:
> %{_libdir}/libflaim.a - see:
>
http://fedoraproject.org/wiki/Packaging/Guidelines#head-2302ec1e1f44202c9cc4bcce24cb711266557ad7

Done.

> - - MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
> (for directory ownership and usability).
> -> Add Reuires: pkgconfig to %package devel

Done.

> - you should use  $RPM_OPT_FLAGS instead of %optflags:
>
http://fedoraproject.org/wiki/Packaging/Guidelines#head-f3d77b27a5d29dfc1f5600ef3fc836f2e317badf

Done.

Updated pkgs at:

http://snecker.fedorapeople.org/libflaim/

I am still working on iFolder and simias which are the other two packages that
form the reqs necessary to get iFolder working on Fedora.

Regards
Chris

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.