[Bug 226514] Merge Review: unix2dos

bugzilla at redhat.com bugzilla at redhat.com
Sun Feb 4 13:07:02 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: unix2dos


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226514


ruben at rubenkerkhof.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|ruben at rubenkerkhof.com      |twaugh at redhat.com
                 CC|                            |ruben at rubenkerkhof.com
               Flag|fedora-review?              |fedora-review-




------- Additional Comments From ruben at rubenkerkhof.com  2007-02-04 08:06 EST -------
Review for release 26.2.2:
* RPM name is OK
* Builds fine in mock
* File list looks OK

Needs work:
* BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
  (wiki: PackagingGuidelines#BuildRoot)
* BuildRequires: perl should not be included
  (wiki: PackagingGuidelines#Exceptions)
* Preserve timestamps when installing files
* Consider using {?dist} in the Release tag

Notes:
* -Wall is already in RPM_OPT_FLAGS

Rpmlint is not silent:

Source RPM:
W: unix2dos summary-not-capitalized unix2dos - UNIX to DOS text file format converter
     Don't use the name in the Summary
W: unix2dos invalid-license distributable
W: unix2dos no-url-tag
W: unix2dos macro-in-%changelog description
W: unix2dos macro-in-%changelog build
W: unix2dos macro-in-%changelog description

rpmlint of unix2dos-2.2-26:
W: unix2dos summary-not-capitalized unix2dos - UNIX to DOS text file format converter
W: unix2dos invalid-license distributable
W: unix2dos no-url-tag


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list