[Bug 225981] Merge Review: lcms

bugzilla at redhat.com bugzilla at redhat.com
Sun Feb 4 13:19:31 UTC 2007

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: lcms


dan at danny.cz changed:

           What    |Removed                     |Added
         AssignedTo|dan at danny.cz                |alexl at redhat.com
                 CC|                            |dan at danny.cz
               Flag|fedora-review?              |fedora-review-

------- Additional Comments From dan at danny.cz  2007-02-04 08:19 EST -------
OK	source files match upstream:
OK	package meets naming and versioning guidelines.
OK	specfile is properly named, is cleanly written and uses macros consistently.
OK	dist tag is present.
OK	build root is correct.
OK	license is open source-compatible. License text included in package.
OK	latest version is being packaged.
OK	BuildRequires are proper.
OK	compiler flags are appropriate.
OK	%clean is present.
OK	package builds in mock (i386).
OK	package installs properly
OK	debuginfo package looks complete.
OK	final provides and requires are sane:
OK	shared libraries are added to the regular linker search paths, ldconfig is run.
OK	owns the directories it creates.
OK	doesn't own any directories it shouldn't.
OK	no duplicates in %files.
OK	file permissions are appropriate.
OK	scriptlets are present and they are sane.
OK	code, not content.
OK	documentation is small, so no -docs subpackage is necessary.
OK	%docs are not necessary for the proper functioning of the package.
OK	headers in devel subpackage.
OK	pkgconfig filesin devel subpackage.
OK	no libtool .la are packaged.
OK	not a GUI app.


BAD	license field does NOT match the actual license.

	The License tag contains LGPL, but the license in the COPYING file and in the
source files headers is different. The Web say it is MIT license.


BAD	 rpmlint is NOT silent.

I: lcms checking
E: lcms zero-length /usr/share/doc/lcms-1.15/ChangeLog
	the ChangeLog could be omited

I: python-lcms checking
W: python-lcms summary-ended-with-dot Python interface to LittleCMS.

Also a newer version 1.16 was already released.

Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

More information about the package-review mailing list