[Bug 225630] Merge Review: buildsys-macros

bugzilla at redhat.com bugzilla at redhat.com
Mon Feb 5 15:17:47 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: buildsys-macros


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225630


roozbeh at farsiweb.info changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |dgregor at redhat.com
               Flag|                            |fedora-review-




------- Additional Comments From roozbeh at farsiweb.info  2007-02-05 10:17 EST -------
rpmlint output:
W: buildsys-macros non-standard-group Development/Buildsystem
W: buildsys-macros incoherent-version-in-changelog 7-1.fc6 7-1.fc7
W: buildsys-macros no-url-tag
W: buildsys-macros no-documentation
W: buildsys-macros non-conffile-in-etc /etc/rpm/macros.disttag

The first two should at least be corrected.

Other random comments:
* Change license to public domain. A 21-byte file is not really worth licensing
as GPL: http://www.gnu.org/licenses/gpl-faq.html#WhatIfWorkIsShort
* Comment line before "Version:" talks about Fedora Core. Should be changed to
Fedora.
* Description field is the same as Summary field. Not good.
* Use %{_sysconfdir} instead of /etc everywhere.
* Consider using echo instead of printf. The printf lines are tricky and not
very legible.
* In the first line that writes to the macros.disttag line, use ">" instead of ">>".
* The package puts files in /etc/rpm without owning that directory or requiring
any package that does so (blocker).
* Change %defattr(-,root,root) to %defattr(-,root,root,-)


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list