fedora-review denied: [Bug 226411] Merge Review: setserial

bugzilla at redhat.com bugzilla at redhat.com
Tue Feb 6 20:32:59 UTC 2007

Bug 226411: Merge Review: setserial
Product: Fedora Extras
Version: devel
Component: Package Review

manuel wolfshant <wolfy at nobugconsulting.ro> has denied Tim Waugh
<twaugh at redhat.com>'s request for fedora-review:

------- Additional Comments from manuel wolfshant <wolfy at nobugconsulting.ro>
Review for Release: 19.2.2

there are a couple of problems with the spec and the patches
* the fhs patch has two errors
+mandir = @bindir@ <-- this should be @mandir@
+	$(STRIP) $(DESTDIR)$(bindir)/setserial -< should not be at all, leads
empty debuginfo
* the readme patch should include references to Fedora, not Red Hat
* the spec does not include the preferred BUILDROOT, does not honor SMP
flags,uses %makeinstall instead of make install
Warning from rpmlint: Summary ends with dot 

I will attach the fixes for all of the above. Please use whatever you find
useful and once corrected I will do the formal full review.

More information about the package-review mailing list