[Bug 226411] Merge Review: setserial

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: setserial


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226411


wolfy at nobugconsulting.ro changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review-




------- Additional Comments From wolfy at nobugconsulting.ro  2007-02-06 15:32 EST -------
Review for Release: 19.2.2

MUSTFIX:
there are a couple of problems with the spec and the patches
* the fhs patch has two errors
+mandir = @bindir@ <-- this should be @mandir@
+       $(STRIP) $(DESTDIR)$(bindir)/setserial -< should not be at all, leads to
empty debuginfo
* the readme patch should include references to Fedora, not Red Hat
* the spec does not include the preferred BUILDROOT, does not honor SMP
flags,uses %makeinstall instead of make install
Warning from rpmlint: Summary ends with dot 


I will attach the fixes for all of the above. Please use whatever you find
useful and once corrected I will do the formal full review.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.