[Bug 225625] Merge Review: bridge-utils

bugzilla at redhat.com bugzilla at redhat.com
Fri Feb 9 14:22:07 UTC 2007

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: bridge-utils


jima at beer.tclug.org changed:

           What    |Removed                     |Added
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |dwmw2 at redhat.com
                 CC|                            |jima at beer.tclug.org
               Flag|                            |fedora-review?

------- Additional Comments From jima at beer.tclug.org  2007-02-09 09:22 EST -------
Review time! :-)

OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
43bbd2a67b59cac3e15d545f8b51df68  bridge-utils-1.1.tar.gz
43bbd2a67b59cac3e15d545f8b51df68  bridge-utils-1.1.tar.gz.1
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
See below - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
See below - No rpmlint output.
OK - final provides and requires are sane.


OK - Should build in mock.
OK - Should build on all supported archs
OK - Should function as described.
OK - Should have dist tag
See below - Should package latest version
2 bugs - check for outstanding bugs on package.


1. The recommended value for BuildRoot is:

%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

You may want to use that.

2. rpmlint says:

rpmlint on ./bridge-utils-1.1-2.fc7.src.rpm
W: bridge-utils setup-not-quiet
E: bridge-utils no-cleaning-of-buildroot %install

Easily fixed.  Add -q to %setup, and "rm -rf $RPM_BUILD_ROOT" after %install.

3. Latest version not used

http://sourceforge.net/project/showfiles.php?group_id=26089 says 1.2 is
available (and has been since 2006-09-20).  Please evaluate whether you
should be using this release instead.

4. Bugs open

There are two open bugs against this package:


I'm not sure either bug is still particularly valid (one is against FC4,
the other looks like it should be resolved).

If you can address the issues above, I think we can call bridge-utils

Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

More information about the package-review mailing list