fedora-review denied: [Bug 226201] Merge Review: nmap

[bugzilla at redhat.com]

Bug 226201: Merge Review: nmap
Product: Fedora Extras
Version: devel
Component: Package Review

Jima <jima at beer.tclug.org> has denied Jima <jima at beer.tclug.org>'s request for
fedora-review:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226201

------- Additional Comments from Jima <jima at beer.tclug.org>
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
ea50419f99472200c4184a304e3831ea  nmap-4.20.tar.bz2
ea50419f99472200c4184a304e3831ea  nmap-4.20.tar.bz2.1
OK - BuildRequires correct
See below - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
See below - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
See below - No rpmlint output.
OK - final provides and requires are sane:

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs
OK - Should function as described.
OK - Should have dist tag
OK - Should package latest version
0 bugs - check for outstanding bugs on package.

1. Not sure if this is a blocker, but the standard format for defattr
now is:

%defattr(-,root,root,-)

People I've talked to have had the opinion that it's a "should."

2. The recommended BuildRoot is:

%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

3. rpmlint says:

rpmlint on nmap-4.20-2.fc7.src.rpm
W: nmap mixed-use-of-spaces-and-tabs (spaces: line 56, tab: line 62)
W: nmap patch-not-applied Patch1: makefile.patch
W: nmap patch-not-applied Patch0: inet_aton.patch

The first one is easy enough to fix if you want to change the multiple
spaces on lines 56-59 to tabs; I don't believe it's a blocker, though.
I don't believe the other two are, either, but if you're done with the
patches... :-)

Also, I had a couple other concerns about the package.	First off, see:

http://fedoraproject.org/wiki/Packaging/Guidelines#head-fcaf3e6fcbd51194a5d0dbc
fbdd2fcb7791dd002

I've successfully tested the package with this change:

-%makeinstall nmapdatadir=$RPM_BUILD_ROOT%{_datadir}/nmap
+make install nmapdatadir=%{_datadir}/nmap DESTDIR=$RPM_BUILD_ROOT

Secondly, there's a pretty major mistake in nmap-4.20-nostrip.patch.  As
I said in an email to Florian La Roche (who, as far as I can tell, added
that patch):

--- snip ---
 In your effort to remove -s's from install lines, you also made this
effective change:

-$(SHTOOL) mkln -f -s $(DESTDIR)$(bindir)/nmapfe $(DESTDIR)$(bindir)/xnmap
+$(SHTOOL) mkln -f $(DESTDIR)$(bindir)/nmapfe $(DESTDIR)$(bindir)/xnmap

 Which has this annoying effect on the build:

ln: `nmapfe': hard link not allowed for directory
...
RPM build errors:
    File not found: /var/tmp/nmap-root/usr/bin/xnmap

 I'm pretty sure that's not what you meant to do. :-)
 I fixed the patch in my local copy and threw it against my buildsys and it
worked fine.  Just thought I'd let you know.
--- snip ---

So, please, add the -s back to the `mkln` part of that line.  The build
fails otherwise. :-P

In closing, if you could address the above issues, I think nmap should	
be cleared for merging.