[Bug 220890] Review Request: libcdaudio - Control operation of a CD-ROM when playing audio CDs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libcdaudio - Control operation of a CD-ROM when playing audio CDs


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220890





------- Additional Comments From Axel.Thimm at ATrpms.net  2007-02-20 19:38 EST -------
(In reply to comment #12)
> (In reply to comment #11)
> It seems there has been a lack of communication between FPC and FESCo. At the
> very least, some members of FESCo appear to be unaware of any changes made to
> the packaging guidelines...

Well, fesco and fpc overlap by > 50% or more, so at least that amount of fesco
should be aware of fpc topics automatically and have perfect communication. :)

(In reply to comment #13)
> its mandatory use it regardless of your personal beliefs the community that 
> you are part of agreed to it.  if it changes at some point in the future

Ahem, the "future" was a week ago. FPC reevaluated this decision and dropped
that buildroot in favour of the mktemp one, the voting was unanimously. But I
don't know whether it was persented to fesco on Thursday and if, whether it was
ratified.

> you will be free to change it then.  until then please abide by the
> guidelines.

Please check fedora-packaging

(In reply to comment #14)
> (In reply to comment #11)
> > I'm from FPC. Yes, we went for using mktemp -ud as the lesser evil. The expected
> > side-effects are that stepped rpmbuilds (using --short-circuit for example)
> > won't work anymore unless you supply a buildroot on the command line.
> 
> Could you post a reproducer for this to fedora-packaging?  -bi --short-circuit
> builds work just fine for me with a mktemp -ud BuildRoot when it's specified in
> a specfile.  OTOH it doesn't work for whatever reason if I set it in
> ~/.rpmmacros (gets evaluated twice in that case), but perhaps that's what you
meant?

Sorry, Ville, I think you are 100% correct and this is a Red Herring. I was just
quoting racor on this w/o thinking too much on my own.

Indeed, since it's not quite sane to use the buildroot outside of %install and
%clean, all that is slightly broken is separating building and cleaning, but
IMHO we can live with that. Of course you will find some people that claim that
%buildroot should be available during %build, too, and I remember such a
discussion on fedora-packaging, perhaps racor was even one of them. We should
better create a guideline against using %buildroot in %prep and %build. :)

So even less evil with the mktemp variant.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.