[Bug 225797] Merge Review: gimp-data-extras

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gimp-data-extras


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225797


nphilipp at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nphilipp at redhat.com         |nobody at fedoraproject.org
       External Bug|                            |http://bugzilla.gnome.org/sh
          Reference|                            |ow_bug.cgi?id=410387
               Flag|fedora-review-              |fedora-review?




------- Additional Comments From nphilipp at redhat.com  2007-02-21 09:20 EST -------
(In reply to comment #1)
> Random first notes:
> * Release (1.1.1) should be an integer. You may also add %{?dist} if you wish.
> * separate the BuildRequires into two lines. It's not very obvious now.
> * change BuildRoot to
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
> * remove the dot at the end of Summary.
> * As /usr/bin is in the execution path, saying /usr/bin/gimptool in the install
> section is not necessary. Just use "gimptool", which makes the spec more legible.

all fixed in CVS

> * Use %defattr (-, root, root, -) instead of %defattr (-, root, root)

I've used "%defattr (-, root, root, 0755)" . Using "-" as dirmode (instead of
none) doesn't make a difference, both mean "keep mode of the directory as found".

> * The license filed says GPL, while there is nothing in the source tarball that
> confirms that. The COPYING file is also empty. (BLOCKER)

filed upstream at http://bugzilla.gnome.org/show_bug.cgi?id=410387

> * You should ship some of the files as %doc (at least AUTHORS, ChangeLog, NEWS,
> and README).
> * The spec file is not UTF-8. (BLOCKER)
> * The install root is not cleaned at the beginning of %install

all fixed in CVS



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.